Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap api in try catch for chall 0 #150

Merged

Conversation

technophile-04
Copy link
Collaborator

Description:

I am sure but for some reason, certain people are facing this issue, when they click "Mint NFT" btn :

Error Image from TG chat

IMG_7449

This doesn't happen to me and everything works fine for me, but a couple of people in the challenge 0 TG group faced this 1, 2

Its mainly caused due infura and ipfs cilent not working properly for certain region / using VPN kind of related discussion on infura

Neverthe less this PR wraps the api in try catch, so that atleast we are able to see cards on frontend ( although without NFT image) but people can move forward and submit the challenge it does not block them

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Probably we need to add the issue and think about workaround for that cases

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🙌🚀

Probably we need to add the issue and think about workaround for that cases

Agree, just created the issue to tackle it in the future: #152

@technophile-04 technophile-04 merged commit 1c35da6 into challenge-0-simple-nft Mar 7, 2024
@technophile-04 technophile-04 deleted the try-catch-addIpfs-api-chall-0 branch March 7, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants