Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yolo mode activated! #205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Yolo mode activated! #205

wants to merge 1 commit into from

Conversation

moltam89
Copy link

Hey guys,

This is kind of the continuation of #167, however I took a completely different approach.
My gut feeling tells me that there should be an easy way to turn any scaffold-eth-2branch into an extension.

This new approach works like this:

  1. Clone scaffold-eth-2 into this repo and switch to the branch we want to create the extension from
  2. yarn create-extension-yolo scaffold-eth-2 {commitHash}
    commitHash is the the last commit which exists in scaffold-eth-2
    This command collects all the modified files since commitHash and creates an extension called scaffold-eth-2
  3. yarn cli -e scaffold-eth-2 --dev --skip yo --yolo
    This command clones scaffold-eth-2, resets it to commitHash and copies the files from the extension.
    Alternatively we can push the extension to github and use yarn cli -e moltam89/UniswapX-extension-yolo --skip yo --yolo

In case of my UniswapX branch the process would look like this:

yarn build:dev
Runs the build script

git clone -b UniswapX https://github.com/moltam89/scaffold-eth-2
Clones moltam89/scaffold-eth-2/UniswapX

yarn create-extension-yolo scaffold-eth-2 beefe9dcd2743aaab3be5b85652b6c2f16162601
Creates the extension

yarn cli -e scaffold-eth-2 --dev --skip yo --yolo
or
yarn cli -e moltam89/UniswapX-extension-yolo --skip yo --yolo
Spins up the instance

Notes:

  • Since currently the main branch of scaffold-eth-2 is used, only hardhat is supported.
  • I don't mean to merge this PR (there are lots of code duplications), this is more like a look at this idea PR.

Cheers,
Tamas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant