Feat(core): Implement file templates to UnifiedTemplate #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AivanF
reviewed
Dec 6, 2021
| if input.get("file"): | ||
| from smart_kit.configs import get_app_config | ||
| app_config = get_app_config() | ||
| template_loader = FileSystemLoader(app_config.JINJA2_TEMPLATES_PATH) |
There was a problem hiding this comment.
Навернре jinja2.FileSystemLoader
intsynko
approved these changes
Dec 6, 2021
dangerink
reviewed
Dec 7, 2021
|
Можете добавить пример использования фичи? Как добавить шаблон в файле? Если не трудно, сделайте сравнение до и после: в строке и в файле. |
SyrexMinus
approved these changes
Jan 24, 2022
dangerink
suggested changes
Jan 25, 2022
"это порядок загрузки. FileRepository из ceph из него получает дикт с шаблоном, его кормим в jinja2.DictLoader" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Привет, не совсем уверен, что можно инициализировать get_app_config в core, но прошу все равно посмотреть, фича нужна для написания jinja2 шаблонов не в строках, а в файлах. app_config нужен для настройки папки templates, не во всех проектах она нужна в references.