-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home Page - Links for more info about the features #106
base: master
Are you sure you want to change the base?
Conversation
I put some links on this page for readers to get more info about Small Basic. Please review this PR.
ERROR in : Template parse errors: Unexpected closing tag "a". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags ("ents/articles/14114.small-basic-the-unique-features.aspx target="_blank">See all the unique features[ERROR ->].
"): /home/vsts/work/1/s/src/app/home/home.component.html@44:166 Unexpected closing tag "a". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags ("/wiki/contents/articles/14114.small-basic-the-unique-features.aspx#Simple target="_blank">Learn more[ERROR ->].
"): /home/vsts/work/1/s/src/app/home/home.component.html@62:160 Unexpected closing tag "a". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags ("/wiki/contents/articles/14114.small-basic-the-unique-features.aspx#Social target="_blank">Learn more[ERROR ->].
"): /home/vsts/work/1/s/src/app/home/home.component.html@70:163 Unexpected closing tag "a". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags ("wiki/contents/articles/14114.small-basic-the-unique-features.aspx#Gradual target="_blank">Learn more[ERROR ->].
"): /home/vsts/work/1/s/src/app/home/home.component.html@84:197 ##[error]Bash exited with code '1'. Finishing: npm install and build |
src/app/home/home.component.html
Outdated
@@ -60,15 +60,15 @@ <h2>Simple</h2> | |||
|
|||
<p> | |||
With smart coding hints from IntelliSense, Small Basic makes writing code | |||
a breeze. | |||
a breeze. <a href=https://social.technet.microsoft.com/wiki/contents/articles/14114.small-basic-the-unique-features.aspx#Simple target="_blank">Learn more</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessibility: link text alone should reflect the link destination. Do not use "click me" or "learn more"
src/app/home/home.component.html
Outdated
@@ -60,15 +60,15 @@ <h2>Simple</h2> | |||
|
|||
<p> | |||
With smart coding hints from IntelliSense, Small Basic makes writing code | |||
a breeze. | |||
a breeze. <a href=https://social.technet.microsoft.com/wiki/contents/articles/14114.small-basic-the-unique-features.aspx#Simple target="_blank">Learn more</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put in quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build broke and link texts need work
Fixed the two issues... Added quotes and gave more detail on linked text.
I put some links on this page for readers to get more info about Small Basic. Please review this PR.