Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rarities filter to Armory #3599

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

atom-skillz
Copy link
Contributor

Adds a way to filter armors and weapons by tier, since in FU the rarity directly linked to the tier of the item. This will help players pick a weapon/armor more easily.

@sayterdarkwynd
Copy link
Owner

sayterdarkwynd commented Oct 21, 2024

While the idea is great and I like where the implementation sits on the interface: clicking on them crashes things because you didnt actually set up groups to do this. The game has no idea what to load. It doesn't filter using that parameter by default.

This also means you clearly did not test the function to see if it operated: please do not submit pull requests without testing.

@atom-skillz
Copy link
Contributor Author

While the idea is great and I like where the implementation sits on the interface: clicking on them crashes things because you didnt actually set up groups to do this. The game has no idea what to load. It doesn't filter using that parameter by default.

This also means you clearly did not test the function to see if it operated: please do not submit pull requests without testing.

Do you have the error message? I am new at modding but I have been testing since it yesterday while playing and i haven't had any issues with the change.
20241021_11h58m51s_grim
20241021_11h59m06s_grim

@sayterdarkwynd sayterdarkwynd merged commit a304b45 into sayterdarkwynd:master Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants