-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a pass at some elemental consistency #3579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d elementalconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is a big chunk of work, primarily addressing weapons that had incorrect elements or element tooltips assigned.
short notes:
fixed many weapons' element icons and added several missing status effect listings on descriptions.
made many weapons have proper elemental inheritance on alts, and fixed many weapons' elements.
fixed an image error.
long notes:
buildfist.lua - added missing handling for element icons
several fist weapon abilities were updated to inherit status effects and elemental type from the primary ability, but not all of them.
similar was applied to staff, spear and scythe spin abilities.
The above was also applied to the Screw Attack ability, which despite having elemental config defined in ability files never used them.
several melee weapons had their element type added so that they no longer did 'default' instead of their listed element.
added missing status effect information to a number of melee weapons.
Save The Queen now properly deals poison damage. It now also applies bee stings and poison to targets hit.
Golden Honey Blade still deals physical damage, but applies burning and beestings on the normal hits (not the altfire however. but that deals fire damage.)
Golden Sea Scion now deals poison damage and applies poison.
wildfire - now fires electric bullets instead of default damage. split bullets included. also, they all electrify. Pretty zappy when used on groups of enemies.
graviton pistol - change element icon to cosmic
phaser - final upgrade now updates description to list frostburn, element icon changes to cosmic
energy lobber - now deals electric instead of poison
corrected hellfireprojectile images to have correct frames file dimensions and image dimensions, as they were causing errors.
Corrected issues with fuflyingslash - lack of handling for physical element, and no check for whether a sound exists.