Improve compatibility with all mods that add dungeons to Garden planet #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edwardspec
commented
Jan 16, 2024
•
edwardspec
commented
- Improved compatibility with all mods that add dungeons to the starting Garden planet.
- Updated description of Ship Repairs quest to not mention removed item (key to the Dark Cavern).
- Fixed quest descriptions where Foraging Table was incorrectly called Foraging Station.
- Updated flavor text in Glitch race description to match their masteries.
Vinalisj no longer gives a key, he just opens the Dark Cavern.
These mods were incompatible, because their dungeons were competing with things like "Dark Cavern entrance", causing them not to spawn. Garden planet was set to have minimum/maximum number of dungeons of 4, and because FU has exactly 4 dungeons that must spawn there, all 4 were guaranteed. But some mods were messing this up. However, as it turns out, we can safely set minumum number of dungeons to a high number (in this case, 10), because the dungeons are planet-unique (can't appear more than once), so if there are only 4 dungeons, and "minumum 10 dungeons" were requested, then only these 4 will spawn (without duplicates), which is exactly what we want. If some mod adds 1 extra dungeon to the Garden planet, then there will just be 5 dungeons, and FU dungeons won't be prevented to spawn. The issue can still occur if player installs so many of these mods that they add 7 or more dungeons, but it's a self-inflicted problem.
edwardspec
force-pushed
the
fix-misc-typos
branch
from
366cf9d
to
a483098
Compare
After the race revamp, they no longer have bonus to bow/mace, but the flavor text wasn't updated to reflect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.