Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: appointment service impl #87

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

maxwellgithinji
Copy link
Contributor

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bugfix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #87 (ae4163a) into develop (101215c) will increase coverage by 1.57%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             develop     #87      +/-   ##
============================================
+ Coverage       5.07%   6.64%   +1.57%     
- Complexity        44      58      +14     
============================================
  Files             43      43              
  Lines           1970    1970              
  Branches         174     174              
============================================
+ Hits             100     131      +31     
+ Misses          1869    1836      -33     
- Partials           1       3       +2     

see 2 files with indirect coverage changes

@maxwellgithinji maxwellgithinji force-pushed the test-appointment-service branch 15 times, most recently from 18c4007 to 06b7163 Compare August 23, 2023 09:06
@maxwellgithinji maxwellgithinji marked this pull request as draft August 23, 2023 09:15
Signed-off-by: maxwellgithinji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants