Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap fetching patient identifiers in try-catch to avert sync f… #124

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

KathurimaKimathi
Copy link
Contributor

…ailure

  • should not fail when no CCC identifier is found when synchronizing patient to MCH backend Additionally:
  • Advance sync patient a litlle bit to cover more code

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bugfix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

…ailure

- should not fail when no CCC identifier is found when synchronizing patient to MCH backend
Additionally:
- Advance sync patient a litlle bit to cover more code

Signed-off-by: Kathurima Kimathi <[email protected]>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #124 (8576d5a) into develop (1ea4db5) will decrease coverage by 0.08%.
The diff coverage is 12.50%.

@@              Coverage Diff              @@
##             develop     #124      +/-   ##
=============================================
- Coverage      48.18%   48.11%   -0.08%     
- Complexity       288      289       +1     
=============================================
  Files             43       43              
  Lines           1982     1987       +5     
  Branches         175      175              
=============================================
+ Hits             955      956       +1     
- Misses           958      962       +4     
  Partials          69       69              
Files Changed Coverage Δ
.../api/service/impl/MyCareHubPatientServiceImpl.java 18.84% <12.50%> (+0.02%) ⬆️

@Salaton Salaton merged commit 353e6cb into develop Sep 26, 2023
2 of 4 checks passed
@Salaton Salaton deleted the assorted-patient-chores branch September 26, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants