Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add url and developers property to pom #121

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Salaton
Copy link
Contributor

@Salaton Salaton commented Sep 18, 2023

In order to ensure a minimum level of quality of the components available in the Central Repository, we have established a number of requirements your deployment components have to meet.

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bugfix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #121 (db03ce3) into develop (b73ba97) will not change coverage.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

❗ Current head db03ce3 differs from pull request most recent head 360ac3b. Consider uploading reports for the commit 360ac3b to get more accurate results

@@            Coverage Diff             @@
##             develop     #121   +/-   ##
==========================================
  Coverage      46.01%   46.01%           
  Complexity       283      283           
==========================================
  Files             43       43           
  Lines           1982     1982           
  Branches         175      175           
==========================================
  Hits             912      912           
  Misses          1006     1006           
  Partials          64       64           

@Salaton Salaton force-pushed the update-pom branch 11 times, most recently from 87716d3 to e6b9ed5 Compare September 19, 2023 09:31
In order to ensure a minimum level of quality of the components available in the Central Repository, we have established a number of requirements your deployment components have to meet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant