Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow immediate & delayed job deletion #106

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Allow immediate & delayed job deletion #106

merged 7 commits into from
Oct 11, 2023

Conversation

saurabhnanda
Copy link
Owner

@saurabhnanda saurabhnanda commented Oct 9, 2023 •
edited
Loading

closes #104

closes #22

@saurabhnanda
Copy link
Owner Author

@tfausak @jappeace @tchoutri

does this look good to you? unless one explicitly opts-in the delayed job deletion thread is not even started, so i'm not expecting any existing code to break.

@saurabhnanda saurabhnanda mentioned this pull request Oct 10, 2023
Open
@saurabhnanda saurabhnanda merged commit 411d5d0 into master Oct 11, 2023
8 checks passed
@saurabhnanda saurabhnanda deleted the job_deletion branch October 11, 2023 05:20
@saurabhnanda saurabhnanda mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchoutri tchoutri tchoutri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make job deletion configurable Implement reaper for failed/stale jobs
2 participants
@saurabhnanda @tchoutri