Basic `onClick` functionality for rendered structuredLang #8

saser · 2017-04-16T20:06:25Z

This PR implements what seems to be correct functionality for updating the state of the web application when constructors are clicked.

When a constructor that does have a trace is clicked, the state of the web application is updated to keep track of what trace was clicked, as well as in what language.
When a constructor without a trace is clicked, the state of the web application changes to indicate that no trace is "active".

Note that the actual dispatch function is not injected, yet, but it will be trivial to substitute later.

We still get warnings, though, since the helper components do not recieve `createOnClick`, so they cannot pass it to their recursive calls to <StructuredExp />.

We still get boatloads of warnings though, since they have only been injected into these components, but they are not actually used.

We are still not using it anywhere, but we do not get any prop type failures anymore, so I assume the injections are working.

Had forgotten about stopping the propagation, but that was easily fixed.

In some other branch, I had changed it to include the `lang` property, but apparently that branch hasn't been merged.

Woohoo, this seems to work flawlessly! (Here's to hoping I didn't jinx it by writing that.)

It it not the most graceful way, but it is better than what was before.

saser · 2017-04-17T09:33:14Z

Just had another look at this, looks good. Merging.

saser added 11 commits April 16, 2017 21:59

Inject dispatch into <StructuredLangTrees />

228e75e

Note that the actual dispatch function is not injected, yet, but it will be trivial to substitute later.

Inject createOnClick into <StructuredExpWrapper />

56037a8

Inject createOnClick into top-level <StructuredExp /> component

3762cf3

We still get warnings, though, since the helper components do not recieve `createOnClick`, so they cannot pass it to their recursive calls to <StructuredExp />.

Inject createOnClick into <Item />, <List /> and <Tuple />

eeaa990

We still get boatloads of warnings though, since they have only been injected into these components, but they are not actually used.

Forgot about the helper component <SurroundAndSeparate />

7680bde

Inject all the createOnClicks

8b1bc29

We are still not using it anywhere, but we do not get any prop type failures anymore, so I assume the injections are working.

Actually create and use onClick functions

20acbc9

Had forgotten about stopping the propagation, but that was easily fixed.

Update the TRACE_ACTIVATED action

c59be4d

In some other branch, I had changed it to include the `lang` property, but apparently that branch hasn't been merged.

Update the shape of the state tree to include lang for highlightedTrace

9811419

Dispatch events when spans are clicked

ed544a7

Woohoo, this seems to work flawlessly! (Here's to hoping I didn't jinx it by writing that.)

More gracefully handle clicking on stuff without traces

86df070

It it not the most graceful way, but it is better than what was before.

saser merged commit 1676201 into master Apr 17, 2017

saser deleted the structlang-onclick branch April 25, 2017 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic `onClick` functionality for rendered structuredLang #8

Basic `onClick` functionality for rendered structuredLang #8

saser commented Apr 16, 2017

saser commented Apr 17, 2017

Basic onClick functionality for rendered structuredLang #8

Basic onClick functionality for rendered structuredLang #8

Conversation

saser commented Apr 16, 2017

saser commented Apr 17, 2017

Basic `onClick` functionality for rendered structuredLang #8

Basic `onClick` functionality for rendered structuredLang #8