Switch from flake8 to ruff - and run various linting cleanups #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to switch from flake8 to ruff as the linter, the motivation here is two fold:
I may have gone overboard with this PR, let me know if I should make it a minimal transition, but I have split it out hopefully into easily digestible commits.
My biggest concern is 949e612 which moves
_patch_criteria
into it's own method, rather than an inline function. This personally reads better to me, but I am not a frequent programmer of algorithms that use functional programming. Happy to revert.