Subnet routes refactoring #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
route_on_active implies that this option is for turning on and off provisioning of routes to active devices. It's the opposite however - turning on and off provisioning to passive devices.
all(... for x in []) yields True, which is desired here, but can still be unexpected behavior to a reader. An explicit check for [] helps readability without changing behavior.
- Clearer variable names
- Sections with section header comments
- More efficient decision logic
So far we're iterating over all routes and `continue` when we want
to skip a route. But multiple checks require iterating over all
networks and/or subnets.
- Every check has to iterate over networks separately
- `continue` can't be used to ignore routes unless we iterate over
networks using list comprehension
So put decision logic into a function ignore_route. In it we iterate
over networks once. If a route is to be ignored (i. e. spared from
deletion) we can return immediately, no matter how deeply nested the
current for-loop is.
- Fix formatting
BenjaminLudwigSAP
force-pushed
the
subnet-routes_refactoring
branch
from
6bfc3de
to
1ae285e
Compare
Since subnet deletion was separated out into the CleanupSubnetRoutes function in c81eb89 it makes sense to keep the names more in line with the naming convention used for other tasks that separate between creation and deletion
notandy
requested changes
Mar 10, 2023
There was a problem hiding this comment.
Rename SyncSubnetRoutes to EnsureSubnetRoutes
<- the name change is not justified since the subnet routes are still removed by the same function - and in fact the same function could also cleanup by providing it an empty selfip array which makes the new "cleanup" function redundant.
BenjaminLudwigSAP
added
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently waiting for fix of member/SelfIP conflict (which already includes some heavy L2 refactoring)
This PR follows up on #204.
So far it stacks onto (i.e. includes) #204, but I will rebase it onto
stable/yoga-m3once #204 is merged.