Refactor health manager #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminLudwigSAP
force-pushed
the
healthmanager
branch
4 times, most recently
from
4569345
to
dcb7060
Compare
BenjaminLudwigSAP
force-pushed
the
healthmanager
branch
2 times, most recently
from
516966e
to
bacf7fd
Compare
NoResultFound has to be catched seperately, because it inherits InvalidRequestError (which makes absolutely no sense, but whatever)
- Log once status manager is done initializing - Rename variables to snake case - Fix typos in docstrings
BenjaminLudwigSAP
force-pushed
the
healthmanager
branch
from
bacf7fd
to
9b2eb15
Compare
Also: - Rename variables - PEP8 - Remove wrong comment. 99496ec did state that it fixed a race condition but I think it was really just an error with non-existent and/or URL encoded member stats. Not quite sure though.
It's directly connected to amphora_messages, so move it right after the declaration.
Add note in update_db.py for clarification and as placeholder for rework of status manager mechanics.
|
You assigned this PR for review, but it has open todos, should we wait for review till you implemented them? |
|
Sorry, I originally included a fix in this PR, but have since pushed that fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #171
TODO: