Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESDs: Allow HTTP to HTTPS redirect via AS3 instead of iRule #123

Open
wants to merge 1 commit into
base: stable/yoga-m3
Choose a base branch
from

Conversation

BenjaminLudwigSAP
Copy link
Collaborator

@BenjaminLudwigSAP BenjaminLudwigSAP commented Nov 3, 2020

The ESD just needs to have 'redirect80' set to true and it will be set accordingly in the HTTPS service AS3 object.

When this is merged we can test in QA simply by temporarily changing the ESD in the Octavia configuration configmap.

Closes #119

The ESD just needs to have 'redirect80' set to True and it will be set
accordingly in the HTTPS service AS3 object.
@notandy
Copy link
Collaborator

notandy commented Nov 3, 2020

Nice short PR, but I it's a bit more complicated:
Users set their redirect_to_http ESD flag in their port 80 listener, which is a SERVICE_HTTP, so this AS3 flag is ignored.
We need to find out which HTTPS listener (443) is related, set the redirect80 flag and (probably, need to be tested) omit the Port 80 AS3 service_http completely.

@BenjaminLudwigSAP BenjaminLudwigSAP changed the base branch from master to stable/yoga-m3 July 27, 2022 15:44
@BenjaminLudwigSAP BenjaminLudwigSAP force-pushed the stable/yoga-m3 branch 2 times, most recently from 67aa389 to edf5dec Compare August 3, 2022 19:07
@BenjaminLudwigSAP BenjaminLudwigSAP changed the title ESDs: Allow redirect via AS3 instead of iRule ESDs: Allow HTTP to HTTPS redirect via AS3 instead of iRule Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement HTTP upgrade via AS3 property instead of iRule
2 participants