Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update harvest: autoscale worker replicas #5946

Merged
merged 4 commits into from
Feb 2, 2024
Merged

update harvest: autoscale worker replicas #5946

merged 4 commits into from
Feb 2, 2024

Conversation

chuan137
Copy link
Member

changes due to netappsd updated to v2, where netappsd master controls worker's replica, based on discovered filers.

# counters:
# - ^comment => comment
# - hidden_fields:
# - comment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this section? Maybe some kind of TODO?

It matches some seemingly inconsistent config below: comment is in the counters as well as in hidden_fields, is that okay?

Copy link
Member Author

@chuan137 chuan137 Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ZAPI configuration, extending is easier. One could just add the changed fileds in a custom file, and harvest will merge them. However, for REST, the entire file needs to be replaced. I requested a feature here.. So the section is about what would be needed when the merging feature is available for REST. But good catch, the section only applies to ZAPI conf. Looks like it is also a bit outdated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hidden_fields is for requesting extra fields that is not returned otherwise.
https://github.com/NetApp/harvest/blob/26e5f2700f928cee206206d1049cbbaa4b5a72ad/docs/configure-rest.md?plain=1#L164

@chuan137 chuan137 merged commit ab1e72d into master Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants