Adding Hierarchical Actor support in actor bundle #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarang10
reviewed
Aug 9, 2024
|
|
||
| @Valid | ||
| private ConsumerConfig consumer; | ||
|
|
There was a problem hiding this comment.
@AshayKing Can you please expose all other relevant fields as well like Retry strategy in the config.
sarang10
reviewed
Aug 9, 2024
| tokenList.add(childrenToken); | ||
|
|
||
| val routingKey = routingKeyGenerator.apply(tokenList.stream().map(String::valueOf).toList()); | ||
| val currentChildrenDefaultData = Objects.nonNull(currentChildrenData.getDefaultData()) ? |
There was a problem hiding this comment.
The current design is to have one common exchange for all the child tenants, however when talking in terms of isolation(lets say where it is an audit/legal requirement), will it be better to have isolation end to end like isolation of exchanges as well ?
added 2 commits
August 10, 2024 13:08
AshayKing
changed the title
r0goyal
reviewed
Sep 12, 2024
| @NoArgsConstructor | ||
| public class HierarchicalActorConfig extends ActorConfig { | ||
|
|
||
| private boolean useParentConfigInWorker = true; |
There was a problem hiding this comment.
Document what this field means
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.