Publish with confirm listener added #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
publish with confirm listener function added TestCase for the publishWithConfirmListener
pranithk
reviewed
Apr 5, 2023
stdout
Outdated
| @@ -0,0 +1,266 @@ | |||
| [INFO] Scanning for projects... | |||
There was a problem hiding this comment.
removing this added by mistake
pranithk
reviewed
Apr 5, 2023
| @@ -35,8 +35,8 @@ | |||
| @Slf4j | |||
| public class NamespacedQueuesTest { | |||
|
|
|||
| private static final int RABBITMQ_MANAGEMENT_PORT = 15672; | |||
| private static final String RABBITMQ_DOCKER_IMAGE = "rabbitmq:3-management"; | |||
| private static final int RABBITMQ_MANAGEMENT_PORT = 5672; | |||
There was a problem hiding this comment.
15672 is for browser
pranithk
reviewed
Apr 5, 2023
| public void start() throws Exception { | ||
| final String exchange = config.getExchange(); | ||
| final String dlx = config.getExchange() + "_SIDELINE"; | ||
| this.publishChannel = connection.newChannel(); |
There was a problem hiding this comment.
reverting this change
pranithk
reviewed
Apr 5, 2023
| @@ -106,17 +114,105 @@ public final long pendingSidelineMessagesCount() { | |||
| return Long.MAX_VALUE; | |||
| } | |||
|
|
|||
| /** | |||
| * Note: Timeout is in MilliSeconds, Function take a list of message as input and return not ack msg as output | |||
There was a problem hiding this comment.
We are taking timeunit, so maybe this comment needs to change?
pranithk
reviewed
Apr 5, 2023
| publishChannel.addConfirmListener((sequenceNumber, multiple) -> { | ||
| messagesAck(sequenceNumber, multiple, outstandingConfirms, publishAckLatch); | ||
| }, (sequenceNumber, multiple) -> { | ||
| nackedMessages.addAll(messagesNack(sequenceNumber, multiple, outstandingConfirms, publishAckLatch)); |
There was a problem hiding this comment.
Why not just assign the return value rather than this?
There was a problem hiding this comment.
Because there can be multiple callback with multiple = true
pranithk
reviewed
Apr 5, 2023
| } | ||
| } | ||
|
|
||
| if (!publishAckLatch.await(unit.toMillis(timeout), TimeUnit.MILLISECONDS)) { |
There was a problem hiding this comment.
What is wrong with publishAckLatch.await(timeout, unit)
pranithk
reviewed
Apr 5, 2023
|
|
||
| long endTime = System.nanoTime(); | ||
|
|
||
| log.info(String.format("Published %d messages with confirmListener in %d ms", messages.size() - outstandingConfirms.size(), |
There was a problem hiding this comment.
We won't know how many messages were submitted, i.e. total messages.
pranithk
reviewed
Apr 5, 2023
| @@ -24,7 +32,7 @@ | |||
| private final ObjectMapper mapper; | |||
| private final String queueName; | |||
|
|
|||
| private Channel publishChannel; | |||
| public Channel publishChannel; | |||
There was a problem hiding this comment.
reverted it, created a function to set publish channel
utkarshrish
reviewed
Apr 19, 2023
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| <groupId>io.appform.dropwizard.actors</groupId> | |||
| <artifactId>dropwizard-rabbitmq-actors</artifactId> | |||
| <version>2.0.28-1</version> | |||
| <version>3.0.2_Test</version> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build failure fix
publish with confirm listener function added
TestCase for the publishWithConfirmListener