Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: Use same org_path as modulesrepo first #22

Merged
merged 13 commits into from
Dec 16, 2024
Merged

refact: Use same org_path as modulesrepo first #22

merged 13 commits into from
Dec 16, 2024

Conversation

jvfe
Copy link
Collaborator

@jvfe jvfe commented Dec 16, 2024

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

jvfe added 13 commits December 16, 2024 07:27
@jvfe
refact: Use same org_path as modulesrepo first
a3f3fdc
@jvfe
refact: Change current_remote to a modulesrepo instance
5ea2fdd
@jvfe
refact: Try using modulesrepo in get_comps
505a9d5
@jvfe
refact: Try using utility functions to grab the yml
375db03
@jvfe
fix: Restore old regex behaviour
63fc8cf
@jvfe
refact: Use parent path instead of regex in comp_utils
a40c07c
@jvfe
refact: Use modulesrepo for current_repo in install
f4cc0fe
@jvfe
refact: Move constants to new file and use MRepo
c0a7a00 
Moves constants from component_utils to constants.py
so that ModulesRepo can be used from inside of component_utils,
thereby avoiding a circular import
@jvfe
Revert "refact: Use modulesrepo for current_repo in install"
c5bebcf 
This reverts commit f4cc0fe.
@jvfe
Reapply "refact: Use modulesrepo for current_repo in install"
ab6e78a 
This reverts commit c5bebcf.
@jvfe
Revert "refact: Move constants to new file and use MRepo"
9903002 
This reverts commit c0a7a00.
@jvfe
refact: Change constants to diff file, use MRepo
fdeeb2c
@jvfe
fix: Change import in test_update
81ac22d
@jvfe jvfe marked this pull request as ready for review December 16, 2024 13:39
@jvfe jvfe merged commit 1ecb3ec into fix/1927 Dec 16, 2024
84 of 86 checks passed
@jvfe jvfe deleted the org_path_fix branch December 16, 2024 13:54
@muffato muffato added the bug Something isn't working label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jvfe jvfe

Labels
bug Something isn't working
Projects
nf-core module & sub-workflow sharing across organizations
Status: Done
Milestone
Enable subworkflows with cross-organi...
Development

Successfully merging this pull request may close these issues.
2 participants
@jvfe @muffato