-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade base box to Bullseye #331
Conversation
PHP test app is good, I submitted fixes for other issues unrelated to the base box upgrade. Python stack is currently broken, with |
Okay, @zenhack, this is ready for your review. Note that on my Windows box, I had to run sandstorm-io/python-app-to-package-for-sandstorm#4 is the simultaneously-needed update to our test app. |
Hmmm, I just pushed that last commit on here for Node, before realizing we waited last time until node-capnp was supported. I don't think apps actually necessarily need node-capnp, and we don't currently have a test app either for that stack, so I think for the moment, I would be in favor of just keeping current as Node 14 goes EOL in a handful of months, and we push actual vagrant-spk releases rarely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I agree with keeping node current, rather than waiting for node-capnp to catch up.
I think we need to address #330 before we merge this, and I also am going to do some testing against our test packages yet. We still need good test packages for some stacks (#298), which is also arguably blocking #290.
This also fixes #255. Node 14 is a supported LTS releae, and node-capnp supports Node 14, so we'll bump that up to be relatively modern as well.