Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_packages failures #519

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Fix test_packages failures #519

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8b3f2e6
rename file to avoid accidental discovery by pytest
rileyjmurray Dec 17, 2024
e6d4d8e
change test_timedep.py to account to floating point issues. One of th…
rileyjmurray Dec 17, 2024
c8ef3cd
ensure simulators match layout type in test_evaltree.py
rileyjmurray Dec 17, 2024
e3e22f7
proper fix for failures in test_timedep.py
rileyjmurray Dec 17, 2024
1018266
revert change to test_evaltree.py (deferring to PR #517)
rileyjmurray Dec 17, 2024
a5a4011
revert out-of-scope change
rileyjmurray Dec 17, 2024
97b1db8
guard against None-valued rep_array and walk on eggshells in rounding…
rileyjmurray Dec 17, 2024
6d4379a
respond to Stefan's comment
rileyjmurray Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pygsti/data/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1730,6 +1730,9 @@ def _add_raw_arrays(self, circuit, oli_array, time_array, rep_array,
# so we need to build this up for all existings sequences:
self._add_explicit_repetition_counts()

dtype_info = _np.finfo(rep_array.dtype)
rep_array = rep_array.round(dtype_info.precision)

if not record_zero_counts:
# Go through repArray and remove any zeros, along with
# corresponding elements of oliArray and timeArray
Expand Down
15 changes: 9 additions & 6 deletions test/test_packages/drivers/test_timedep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,20 @@ def test_time_dependent_datagen(self):
ds = pygsti.data.simulate_data(mdl, circuits, num_samples=100,
sample_error='none', seed=1234, times=[0,0.1,0.2])

self.assertArraysEqual(ds[Circuit([Label('Gi',0)], line_labels=(0,))].time, np.array([0., 0., 0.1, 0.1, 0.2, 0.2]))
self.assertArraysEqual(ds[Circuit([Label('Gi',0)], line_labels=(0,))].reps, np.array([100., 0., 95., 5., 90., 10.]))
self.assertArraysEqual(ds[Circuit([Label('Gi',0)], line_labels=(0,))].outcomes, [('0',), ('1',), ('0',), ('1',), ('0',), ('1',)])
dsr = ds[Circuit([Label('Gi',0)], line_labels=(0,))]
self.assertArraysEqual(dsr.time, np.array([0., 0., 0.1, 0.1, 0.2, 0.2]))
self.assertArraysEqual(dsr.reps, np.array([100., 0., 95., 5., 90., 10.]))
self.assertArraysEqual(dsr.outcomes, [('0',), ('1',), ('0',), ('1',), ('0',), ('1',)])

# sparse data
ds2 = pygsti.data.simulate_data(mdl, circuits, num_samples=100,
sample_error='none', seed=1234, times=[0,0.1,0.2],
record_zero_counts=False)
self.assertArraysEqual(ds2[Circuit([Label('Gi',0)], line_labels=(0,))].time, np.array([0., 0.1, 0.1, 0.2, 0.2]))
self.assertArraysEqual(ds2[Circuit([Label('Gi',0)], line_labels=(0,))].reps, np.array([100., 95., 5., 90., 10.]))
self.assertArraysEqual(ds2[Circuit([Label('Gi',0)], line_labels=(0,))].outcomes, [('0',), ('0',), ('1',), ('0',), ('1',)])
ds2r = ds2[Circuit([Label('Gi',0)], line_labels=(0,))]
self.assertArraysEqual(ds2r.time, np.array([0., 0.1, 0.1, 0.2, 0.2]))
self.assertArraysEqual(ds2r.reps, np.array([100., 95., 5., 90., 10.]))
self.assertArraysEqual(ds2r.outcomes, [('0',), ('0',), ('1',), ('0',), ('1',)])
return

def test_time_dependent_gst_staticdata(self):

Expand Down
Loading