Variants #127
Merged
Variants #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amberchow8
commented
Nov 2, 2024
amberchow8
commented
- Closes Display and add variants on front end #122
- Closes Create API endpoint to return variant data based on server code #119
elvincheng3
reviewed
Nov 13, 2024
| }); | ||
| await study.updateOne({ $push: { batteries: task._id } }); | ||
| const populated = await task.populate<{ battery: IBattery }>("battery"); | ||
| return [200, populated]; | ||
| } | ||
| }; | ||
|
|
||
| export const getVariant = async (serverCode: string): APIResponse<object> => { |
There was a problem hiding this comment.
Can we specify the type of the response?
| throw new HttpError(400, "Missing serverCode in query parameters"); | ||
| } | ||
|
|
||
| const study = await Study.findOne({ |
There was a problem hiding this comment.
This works, but I wonder if we'd be able to query directly on variants by server code rather than go through the studies themselves.
There was a problem hiding this comment.
I don't think we can because right now variants are only contained inside the Study model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.