Fix parsing fail
error for Parse phase
#22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14 #15
This pull request mainly fixes most of the common errors in the scraper's Parse phase (
parsing fail
,unexpected end of token
,ambiguous grammar
) by doing the followingSUBSUBHEADER
(basically aSUBHEADER
but with indentation). This header sometimes doesn't have any meaning (see CS and English's 19th century section for an example), but other times it does. This is mainly here so that we have more options to parse later on (in this PR the Parse Phase just ignore the subsubheader token and the comment).ambiguous grammar
error)With this PR, most of the errors in the Parse Phase are gone. If you run the scraper for 2023, there are only 13 Parse Phase errors, and all of them are specific to one major.
For future works
XOM
#16 is the main focus now since a lot of majors has errors relating to thisUnknown catalog type
- some majors just don't contain the word "major", "minor" or "concentration" in their name