Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor endpoints folder, types, and missing data #767

Merged
merged 6 commits into from
Dec 8, 2024
Merged

Conversation

denniwang
Copy link
Contributor

Description

I added minor endpoints (pretty much refactoring the major folder). Added a couple of types for minors, will need to be heavily reviewed.

Closes # (issue number)

Type of change

Please tick the boxes that best match your changes..

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

This has not been tested yet, Kobe will teach me at the next standup

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 8:31pm

@denniwang denniwang requested a review from KobeZ123 November 12, 2024 21:14
not sure how to run the collator
@denniwang
Copy link
Contributor Author

HAS NOW BEEN TESTED. API ENDPOINT WORKS

@denniwang denniwang changed the base branch from main to minors-for-2024 November 24, 2024 20:28
@denniwang denniwang marked this pull request as ready for review November 24, 2024 20:29
Base automatically changed from minors-for-2024 to main November 24, 2024 20:29
packages/api/src/minor/minor.service.ts Outdated Show resolved Hide resolved
packages/common/src/types.ts Outdated Show resolved Hide resolved
@Suraj-Ram Suraj-Ram merged commit 5884459 into main Dec 8, 2024
7 checks passed
@Suraj-Ram Suraj-Ram deleted the minor-endpoints branch December 8, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants