Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coachmark (Welcome Wagon) #732

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Add coachmark (Welcome Wagon) #732

merged 3 commits into from
Apr 10, 2024

Conversation

BrandonLim8890
Copy link
Contributor

Description

Adds a coachmark when no plan is selected. The coachmark will only show when no plan is selected, and closes when the add course modal opens up.

image

Closes #712

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Tested by running localhost

  • Test A
  • Test B

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

@BrandonLim8890 BrandonLim8890 requested a review from AngelaZQ1 April 5, 2024 17:49
@BrandonLim8890 BrandonLim8890 self-assigned this Apr 5, 2024
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Apr 10, 2024 9:25pm

@Suraj-Ram
Copy link
Contributor

LGTM!

@AngelaZQ1
Copy link
Contributor

Looks good, only thing is that if the user for some reason decides to add transfer course without creating a plan first it looks like this:
Screenshot 2024-04-10 at 1 12 51 PM

The larger issue is probably the no plan selected page being kinda ugly and unintuitive. Maybe we could just remove the transfer courses section when the user hasn't created a plan yet?

Copy link
Contributor

@AngelaZQ1 AngelaZQ1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BrandonLim8890 BrandonLim8890 merged commit 1e31164 into main Apr 10, 2024
6 of 7 checks passed
@BrandonLim8890 BrandonLim8890 deleted the blim/welcome-wagon branch April 10, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Welcome Wagon UX
3 participants