Email jwt timeout (#640)

* Use transfer courses in getting req errors (#613) * Transfer courses add to only pre-req errors (#613) * Format * Set timeout on JWT in confirmation emails * JWT token expiration time fix * remove formatting change
sandboxnu · Nov 2, 2023 · 51fe366 · 51fe366
1 parent a719fbe
commit 51fe366
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/packages/api-v2/.env.development b/packages/api-v2/.env.development
@@ -5,10 +5,11 @@ POSTGRES_PASSWORD=graduatenu
 POSTGRES_DATABASE=dev
 JWT_SECRET_KEY=chungusdevs
 # 1 day in milliseconds (1000 x 60 x 60 x 24)
-JWT_EXPIRE_TIME=86400000 
+JWT_EXPIRE_TIME='86400s'
 PORT=3001
 NODE_ENV=development
-JWT_EXPIRE_TIME_EMAIL=21600
+# 15 minutes in milliseconds
+JWT_EXPIRE_TIME_EMAIL='900s'
 EMAIL_CONFIRMATION_URL=http://localhost:3002/confirmEmail
 EMAIL_SERVICE=gmail
 EMAIL_USER=[insert email from notion]

diff --git a/packages/api-v2/src/email/email.module.ts b/packages/api-v2/src/email/email.module.ts
@@ -13,7 +13,7 @@ import { EmailConfirmationController } from "src/emailConfirmation/emailConfirma
     JwtModule.register({
       secret: process.env.JWT_SECRET_KEY,
       signOptions: {
-        expiresIn: process.env.JWT_EXPIRE_TIME,
+        expiresIn: process.env.JWT_EXPIRE_TIME_EMAIL,
       },
     }),
   ],

diff --git a/packages/frontend-v2/utils/plan/preAndCoReqCheck.ts b/packages/frontend-v2/utils/plan/preAndCoReqCheck.ts
@@ -14,7 +14,7 @@ import {
 } from "@graduate/common";
 
 export const getCoReqWarnings = (
-  schedule: Schedule2<unknown>,
+  schedule: Schedule2<unknown>
 ): CoReqWarnings => {
   const errors: CoReqWarnings = {
     type: "coreq",
@@ -30,7 +30,7 @@ export const getCoReqWarnings = (
 };
 
 export const getCoReqWarningsSem = (
-  term: ScheduleTerm2<unknown>,
+  term: ScheduleTerm2<unknown>
 ): TermError => {
   const seen: Set<string> = new Set();
   const coReqErrors: TermError = {};
@@ -62,8 +62,8 @@ export const getPreReqWarnings = (
       spring: getPreReqWarningSem(year.spring, seen),
       summer1: getPreReqWarningSem(year.summer1, seen),
       summer2: getPreReqWarningSem(year.summer2, seen),
-    }))
-  }
+    })),
+  };
   return preReqErrors;
 };
 
@@ -135,8 +135,6 @@ const isOrCourse = (course: INEUReq): course is INEUOrReq => {
   return (course as INEUOrReq).type === "or";
 };
 
-const isError = (
-  error: INEUReqError | undefined
-): error is INEUReqError => {
+const isError = (error: INEUReqError | undefined): error is INEUReqError => {
   return !!error;
 };