Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

165 export test data #193

Merged
merged 12 commits into from
Jul 7, 2022
Merged

165 export test data #193

merged 12 commits into from
Jul 7, 2022

Conversation

Octillerysnacker
Copy link
Contributor

Closes #165 . Redesigned admin screen and enabled export of test data.
image
image
image

@Octillerysnacker Octillerysnacker linked an issue Jun 16, 2022 that may be closed by this pull request
Implement Admin Home/Export screens Re-design #186
Closed
3 tasks
@Octillerysnacker Octillerysnacker linked an issue Jun 16, 2022 that may be closed by this pull request
As a user, I want to see a loading indicator when exporting data from the app. #183
Closed
shashjar
shashjar reviewed Jun 26, 2022
View reviewed changes
frontend/App.tsx
@@ -70,7 +70,7 @@ export default function App() {
<Stack.Screen name="HomeScreen" component={Homescreen} options={{ gestureEnabled: false, headerBackVisible: false }} />
<Stack.Screen name="SettingsScreen" component={AccountSettings} />
<Stack.Screen name="GameScreen" component={GameScreenFlow} options={{
headerTitle: () => { return <Text style={{color:"#5eafdf", fontSize:20}}>Vocabulary Practice</Text> },
headerTitle: () => { return <Text style={{ color: "#5eafdf", fontSize: 20 }}>Vocabulary Practice</Text> },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a note here that we'll probably have to update the fonts in a few files. Left a note on #196 (the fonts PR) as well. We can merge this PR in first and then handle the conflicts/update fonts in that PR since we're waiting on updating the fonts in the tutorial pictures anyway.

Relevant files: App.tsx, PrimaryButton.tsx, and adminScreen.tsx

@shashjar shashjar mentioned this pull request Jun 26, 2022
Open
@shashjar
Copy link
Contributor

Got the below error for both Export Practice CSV and Export Test CSV after the following steps:

  1. With no data in database, was able to export both practice csv and test csv --> email was generated with no actual CSV attached, was able to send.
  2. Then played a few sessions/rounds
  3. Then was able to export the practice csv --> email was generated with the CSV, CSV contained the correct information and received via email.
  4. Then completed the test
  5. Then attempted to export the test csv, got the below error. Also get this error now attempting to export the practice csv.

Status: email Error: The file does not exist. Given path: /var/mobile/Containers/Data/Application/D0062C7B-45CA-4562-A107-CC45C2A6A44E/Library/Caches/ExponentExperienceData/%40flow-in-the-field%2Fflow-in-the-field/export.csv.
written to file:///var/mobile/Containers/Data/Application/D0062C7B-45CA-4562-A107-CC45C2A6A44E/Library/Caches/ExponentExperienceData/%2540flow-in-the-field%252Fflow-in-the-field//export.csv

shashjar added a commit that referenced this pull request Jul 2, 2022
@shashjar
Finished Consent Screen
1410274 
Placeholder version of consent copy text has been uploaded to production
Firestore as well as emulator db. Consent screen is finished (apart from
any styling we want to change and of course the copy text itself). Admin
screen currently just has a text input and a save button to update the
text stored in Firestore. Will finalize admin screen once PR #193
(export test data) is merged into dev.
@emaela
Copy link
Collaborator

emaela commented Jul 7, 2022

Please wrap the admin screen a ScrollView :)

@Octillerysnacker Octillerysnacker changed the base branch from dev to 10-firebase-emulator July 7, 2022 23:46
@Octillerysnacker Octillerysnacker changed the base branch from 10-firebase-emulator to dev July 7, 2022 23:46
emaela
emaela approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@emaela emaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Octillerysnacker Octillerysnacker merged commit 5e4f3d0 into dev Jul 7, 2022
shashjar added a commit that referenced this pull request Jul 21, 2022
@shashjar
Created Consent Form Screen + Added Admin Ability to Edit Consent For…
a169ec6 
…m Text (#205)

* started adding consent screen doesn't really work rn tho

* Finished Consent Screen

Placeholder version of consent copy text has been uploaded to production
Firestore as well as emulator db. Consent screen is finished (apart from
any styling we want to change and of course the copy text itself). Admin
screen currently just has a text input and a save button to update the
text stored in Firestore. Will finalize admin screen once PR #193
(export test data) is merged into dev.

* Added edit/save consent text capability on admin screen

* Changed consent screen to title case

* Moved consent screen out of screens dir temporarily

* Moved ConsentScreen back into screens directory

* Added automatic scroll to bottom of screen when keyboard is opened
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashjar shashjar shashjar left review comments

@emaela emaela emaela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Data Export & Collection
3 participants
@Octillerysnacker @shashjar @emaela