16 Replaced all fonts with Montserrat #196
Conversation
There was a problem hiding this comment.
The font looks good to me, except for the bug noted in #195.
However, I have a thought on centralizing the font changes: currently the change is made by updating the styling for each component to include a fontFamily property, but I was thinking that another possibility would be to create custom Text components with the appropriate font styling and then update the screens to use those custom Text components. So we could have something like a BoldText component that is styled with Montserrat_700Bold and so on (perhaps with better naming).
My reasoning for this is that in the (very unlikely) case that we change the font type, size or boldness that we want for a certain type of text in the app (header text, button text, body text), we could change all of that type of text by editing one component file rather than each file that has that type of text.
Of course, this may have drawbacks I haven't considered, what are your thoughts on this?
|
Note: we should have edit access to Figma, so the font for tutorial images should be able to be updated |
|
Added Still have to update fonts in tutorial pictures. Settings page looks a little wonky - will have to update this. Wait for #205 to be merged into |
Switched order of end session and next round buttons
There was a problem hiding this comment.
Pretty much everything looks good to me, I just noticed:
- The 'change password' button on the Settings screen is cut off (horizontally), we should make it wider
- The 'done' button on the Test End screen is cut off (vertically), we should make it longer/adjust padding
|
Fixed the formatting issues for the buttons on the Settings screen and the Test Results screen. I changed the buttons on the Settings screen to be centered because I think it looks better but let me know if you think we should change back to right-aligned. |
Changes
Added
RegularText,MediumText, andBoldTextcomponents, and updated the code to use these. Also merged indevand handled the conflicts. Fonts are imported and loaded in inApp.tsx. There are constants set inconstants/fonts.tsxfor the strings of each font type, to be used for styling. If we change fonts at any point, we will only have to change the imports anduseFontsstatement inApp.tsxand the declarations inconstants/fonts.tsx. Updated fonts in tutorial pictures.Also edited game screen to switch order of buttons.
end sessionis now on the left andnext roundis now on the right, to favor right-handed players. The corresponding tutorial image was updated. This was issue #206.Also fixed the Ananas-Pineapple formatting issue on Test Question 32. This was issue #195.
TODOs
Fonts
Closes #16
Closes #206
Closes #195