Logic to score activities

[RishikeshNK]

Closes #126

Description

Things you especially want reviewed

Screenshots if Applicable

Checklist

• Ticket number in PR title
• Add ticket number to ("Closes #")
• Move status to Code Review in GH Board
• People added to reviewers
• Asked for Review in Slack

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
faculty-activity-tracker	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 6, 2023 9:39pm

[maxpinheiro]

looking good, just a few small suggestions.

also, I'm not sure if I missed this, but where is the redux store being initialized with the professor's score? will the ProfessorScoreCard render correctly on initially loading before we ever update the score?

[RishikeshNK]

looking good, just a few small suggestions.

also, I'm not sure if I missed this, but where is the redux store being initialized with the professor's score? will the ProfessorScoreCard render correctly on initially loading before we ever update the score?

@maxpinheiro

My idea was to initialize it as null initially. Then, when a user visits the /merit/professors/[professorId] route, the fetched ProfessorScore is dispatched to the Redux store (See updateComputedProfessorScoreForUser). The ProfessorScoreCard component gets the initial state from the store (using useSelector). If it is null, we don't render the component; otherwise, we use the global reference of the professor score for that user.

I tried it out quite a bit -- the dispatch from the page happens almost instantaneously so the variable in the Redux store is only null for the first render (you won't notice it!). You can also try it out for yourself in the Vercel preview environment. Do you think there is a cleaner way of doing this?

[maxpinheiro]

👍

[RishikeshNK]

Manually tested. All cases work as intended.

[Suraj-Ram]

Awesome!