Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scraped course data with new CRN link #209

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

Lucas-Dunker
Copy link
Member

Purpose

Northeastern changed their provider for CRN data in their courses, meaning that all of our URL's no longer work. This ticket changes our scraper to get URL's from their new provider.

Tickets

Ticket

Contributors

@Lucas-Dunker

Feature List

  • Replace the old, now-defunct CRN link to the new, functional one.

Reviewers

Primary:
@sebwittr @pranavphadke1

Secondary:
@ananyaspatil

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 80.439%. remained the same
when pulling 6a0191c on ld_updateCRN
into cdce629 on master.

Copy link
Contributor

@pranavphadke1 pranavphadke1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lucas-Dunker Lucas-Dunker merged commit cd9536f into master Nov 27, 2023
7 checks passed
@Lucas-Dunker Lucas-Dunker deleted the ld_updateCRN branch November 27, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants