Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp/mark past terms inactive 3 #202

Merged
merged 15 commits into from
Mar 17, 2024
Merged

Conversation

pranavphadke1
Copy link
Contributor

Purpose

Right now we scrape past semesters while we only care about current and future semesters. This pr adds an "active" field to each termInfo (schema representing a term).

Tickets

Contributors

@pranavphadke1

Feature List

  • added an "active" field to termInfo prisma schema
  • When fetching all termInfos, marks whether the termInfo is active

Reviewers

Primary:
@Lucas-Dunker
@sebwittr

Secondary:
@allychao

@coveralls
Copy link
Collaborator

coveralls commented Oct 25, 2023

Coverage Status

coverage: 80.481% (+0.04%) from 80.439%
when pulling 1051274 on pp/mark-past-terms-inactive-3
into d81126a on master.

@pranavphadke1 pranavphadke1 marked this pull request as ready for review November 5, 2023 20:34
Copy link
Member

@Lucas-Dunker Lucas-Dunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can move on to tests! Just check out my feedback concerning the yarn.lock file

yarn.lock Outdated Show resolved Hide resolved
@Lucas-Dunker Lucas-Dunker removed their request for review January 23, 2024 15:11
Copy link
Contributor

@sebwittr sebwittr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks aight

@sandboxnu sandboxnu deleted a comment from sebwittr Mar 17, 2024
@pranavphadke1 pranavphadke1 merged commit a9da0fc into master Mar 17, 2024
7 checks passed
@pranavphadke1 pranavphadke1 deleted the pp/mark-past-terms-inactive-3 branch March 17, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants