Check player is not null before player.trigger('resize') event #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching manifests in demo site using
Set Manifest
form, the player instance is set to null momentarily. During this windowplayer.trigger('resize')
is getting called because, the resize event on window is fired when the component tree is cleared when manifest URL in theSet Manifest
form is emptied or changed.Adding this check prevents the code from trying to emit the 'resize' event on a null instance of the player causing the page to crash. However this doesn't break the resize functionality, as this function is called again when player instance is properly set.