Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOUtil.openFileForMd5CalculatingWriting() puts the md5 file in the wrong place. #1682

Closed
lbergelson opened this issue Aug 18, 2023 · 1 comment
Closed

IOUtil.openFileForMd5CalculatingWriting() puts the md5 file in the wrong place. #1682

lbergelson opened this issue Aug 18, 2023 · 1 comment
Assignees
@takutosato
Labels
bug

Comments

@lbergelson
Copy link
Member

lbergelson commented Aug 18, 2023 •
edited
Loading

It looks like I introduced a bug in IOUtil.openFileForMd5CalculatingWriting(). It appears to resolve filename/.md5 instead of filename.md5. We never noticed because it doesn't have tests.
@lbergelson lbergelson added the bug label Aug 18, 2023
@lbergelson lbergelson changed the title IOUtill.IOMd5CalculatingOutputStream() puts the md5 file in the wrong place. IOUtil.openFileForMd5CalculatingWriting() puts the md5 file in the wrong place. Aug 18, 2023
@lbergelson lbergelson mentioned this issue Aug 18, 2023
Merged
5 tasks
@takutosato takutosato self-assigned this Aug 23, 2023
@lbergelson
Copy link
Member Author

This was fixed in #1681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@takutosato takutosato

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lbergelson @takutosato