Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there are a couple of front-end compilers, specifically looking at #227 and #197, I want to tie things together into a nice bow by extending #161 with (optional) richer source position information as discussed in part in #191.
To support something span-like, this pr adds an optional
pos_end
field to describe the end line/column of the position.To provide source code for the error message, this pr adds an optional
src
field which is an absolute path to the original file that this position points to. Note that thesrc
field does not need to be the same across the entire Bril program.Each is currently described as their own field to be compatible with the original specification, but I would probably like to combine them into one object if that's fine. Something like