Merge pull request rails#51969 from npezza93/insert-all-fix

Parameterize table_name when constructing insert alias to avoid syntax error when table_name contains the database name for mysql

activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb

@@ -644,7 +644,7 @@ def build_insert_sql(insert) # :nodoc:
         # MySQL 8.0.19 replaces `VALUES(<expression>)` clauses with row and column alias names, see https://dev.mysql.com/worklog/task/?id=6312 .
         # then MySQL 8.0.20 deprecates the `VALUES(<expression>)` see https://dev.mysql.com/worklog/task/?id=13325 .
         if supports_insert_raw_alias_syntax?
-          values_alias = quote_table_name("#{insert.model.table_name}_values")
+          values_alias = quote_table_name("#{insert.model.table_name.parameterize}_values")
           sql = +"INSERT #{insert.into} #{insert.values_list} AS #{values_alias}"
 
           if insert.skip_duplicates?

activerecord/test/cases/insert_all_test.rb

@@ -811,6 +811,18 @@ def test_upsert_all_with_unique_by_fails_cleanly_for_adapters_not_supporting_ins
     assert_match "#{ActiveRecord::Base.lease_connection.class} does not support :unique_by", error.message
   end
 
+  if current_adapter?(:Mysql2Adapter, :TrilogyAdapter)
+    def test_insert_all_when_table_name_contains_database
+      database_name = Book.connection_db_config.database
+      Book.table_name = "#{database_name}.books"
+
+      assert_nothing_raised do
+        Book.insert_all! [{ name: "Rework", author_id: 1 }]
+      end
+      Book.table_name = "books"
+    end
+  end
+
   private
     def capture_log_output
       output = StringIO.new