Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding FromSlicePtrNotNil #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

samber
Copy link
Owner

@samber samber commented Jul 26, 2024

Maybe we could name this helper differently.

Also, we could return a boolean when at least 1 nil value is detected and dropped. (see lo.FromAnySlice)

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (cb150f5) to head (0dabc9c).
Report is 18 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   94.46%   94.48%   +0.01%     
==========================================
  Files          17       17              
  Lines        2712     2718       +6     
==========================================
+ Hits         2562     2568       +6     
  Misses        148      148              
  Partials        2        2              
Flag Coverage Δ
unittests 94.48% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants