-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3007.x] Add started event to PublishServer #66994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a started event that gets set after the server transport is ready for clients to connect. - Wait on publish servers start while the master process is starting up.
salt-project-bot-prod-environment
bot
changed the title
Add started event to PublishServer
[3007.x] Add started event to PublishServer
Oct 24, 2024
twangboy
previously approved these changes
Oct 25, 2024
twangboy
previously approved these changes
Oct 25, 2024
dwoz
force-pushed
the
issue/3007.x/66993
branch
from
October 25, 2024 23:43
5bc0415
to
a71b8fa
Compare
dwoz
force-pushed
the
issue/3007.x/66993
branch
from
October 25, 2024 23:49
a71b8fa
to
0ee4271
Compare
dwoz
force-pushed
the
issue/3007.x/66993
branch
from
October 29, 2024 01:25
d4549cc
to
4f21b45
Compare
dwoz
force-pushed
the
issue/3007.x/66993
branch
from
October 29, 2024 10:06
47543ec
to
d6e27d6
Compare
twangboy
approved these changes
Oct 29, 2024
I agree a method like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes #66993
Previous Behavior
Publish clients in the master process could encounter exceptions while trying to connect.
New Behavior
Publish clients within the master processes connect without error.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.