requisite_any: dont fall in an infinite loop when req doesnt exist #55777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Maybe this one is related: #55542 |
|
re-run full all |
|
@mattp- Looks like this change causes a bunch of tests to fail. |
twangboy
previously approved these changes
Feb 11, 2021
|
@dwoz Please rebase and address the conflicts |
twangboy
approved these changes
Jan 3, 2024
|
This fix was probably addressed by #66135, but a test could still be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #50689
What does this PR do?
the missing req logic wasn't picking up the _any variants causing an
infinite loop. this fixes that.
What issues does this PR fix or reference?
not sure if any outstanding issues, but if you try to run a state with onchange_any: something_nonexistant the state engine will recursively loop and stacktrace.
Tests written?
Yes
Commits signed with GPG?
Yes