Take stdout redirection out of daemonization for #1096

saltstack · Jul 29, 2012 · 63d6e96 · 63d6e96
1 parent ae5325f
commit 63d6e96
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/salt/utils/__init__.py b/salt/utils/__init__.py
@@ -179,10 +179,14 @@ def daemonize():
         log.error(msg.format(exc.errno, exc.strerror))
         sys.exit(1)
 
-    dev_null = open('/dev/null', 'rw')
-    os.dup2(dev_null.fileno(), sys.stdin.fileno())
-    os.dup2(dev_null.fileno(), sys.stdout.fileno())
-    os.dup2(dev_null.fileno(), sys.stderr.fileno())
+    # A normal daemonization redirects the process output to /dev/null.
+    # Unfortunately when a python multiprocess is called the output is
+    # not cleanly redirected and the parent process dies when the
+    # multiprocessing process attemps to access stdout or err.
+    #dev_null = open('/dev/null', 'rw')
+    #os.dup2(dev_null.fileno(), sys.stdin.fileno())
+    #os.dup2(dev_null.fileno(), sys.stdout.fileno())
+    #os.dup2(dev_null.fileno(), sys.stderr.fileno())
 
 
 def daemonize_if(opts, **kwargs):