Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sm/default-wait-on-report #763

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sm/default-wait-on-report #763

wants to merge 3 commits into from

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Sep 26, 2023 •
edited
Loading

What does this PR do?

makes 0 the default wait.

  • sets it into the deployOptions as 0 when the user doesn't specify a wait
  • avoids the potential for undefined minutes in the table output
  • makes help clear about what's going to happen with the flag
    • -w, --wait=<minutes> [default: 0 minutes] Number of minutes to wait for command to complete and display results.

@mshanemc mshanemc mentioned this pull request Sep 26, 2023
Merged
Base automatically changed from sh/nomadic-deploy to main September 27, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mshanemc