Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use glob package rather than node:fs #4677

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

nolanlawson
Copy link
Collaborator

Details

Follow-up to #4673 to unbreak the tests. We are running tests in Node v20 and can't use globSync from 'node:fs' just yet.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner October 21, 2024 22:39
@nolanlawson nolanlawson enabled auto-merge (squash) October 21, 2024 22:49
@nolanlawson nolanlawson merged commit bf7be3f into master Oct 21, 2024
11 checks passed
@nolanlawson nolanlawson deleted the nolan/globodyglob branch October 21, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants