fix(shadow-to-light): correctly transform imported .css #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Mar 2, 2024
| # intentionally test with a relative file path since that's what most users will do | ||
| cd /tmp/lwc-codemod-tests | ||
| node "$CLI_PATH" "${TRANSFORM}" "${TRANSFORM}/${DIR}" | ||
| cd - |
There was a problem hiding this comment.
This is not strictly necessary for the repro, but I feel like it's a good safety measure. Most users will do npx lwc-codemod <mod> ./path/to/something rather than provide a full absolute path.
divmain
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #25 (error when trying to delete the same
.cssfile more than once) as well as fixing an additional issue, which is thatshadow-to-lightwas not properly transforming:to
There is an additional issue where we don't handle
import stylesheet from './notReferencedByTemplate.css'but I'll open a separate issue for that.