fix: update dependencies, require Node 18+ #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jan 18, 2024
| } | ||
|
|
||
| return files | ||
| } |
There was a problem hiding this comment.
glob and its various cousins (e.g. fast-glob) were causing too many problems due to transitive dependencies breaking due to ESM vs CJS. So I got rid of glob entirely.
nolanlawson
commented
Jan 18, 2024
| .filter(_ => _.endsWith('/input')) | ||
| .map(_ => path.resolve(root, _)) | ||
|
|
||
| for (const dirname of inputDirs) { |
There was a problem hiding this comment.
This function is only used internally; it did not need to be so complicated.
wjhsf
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: require Node 18+