feat!: update dependency to eslint v9 @W-17445058 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: dropping support for ESLint v7 and v8. The only supported option is ESLint v9
ravijayaramappa
commented
Dec 20, 2024
| @@ -175,29 +175,6 @@ testRule('no-node-env-in-ssr', { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Duplicate test
ravijayaramappa
commented
Dec 20, 2024
| @@ -175,29 +175,6 @@ testRule('ssr/no-node-env', { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Duplicate test
ravijayaramappa
commented
Dec 20, 2024
| @@ -66,17 +66,6 @@ testRule('valid-wire', { | |||
| code: `import { wire } from 'lwc'; | |||
| import getFoo from 'adapter'; | |||
|
|
|||
| class Test { | |||
There was a problem hiding this comment.
Duplicate tests here as well
wjhsf
approved these changes
Dec 20, 2024
lib/rules/no-async-operation.js
Outdated
| return { | ||
| CallExpression(node) { | ||
| const { callee } = node; | ||
| const scope = context.getScope(); | ||
| const scope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope(); |
There was a problem hiding this comment.
Suggested change
| const scope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope(); | |
| const scope = getScope(context, node); |
Since we've got the helper for it. 🤷
ravijayaramappa
force-pushed
the
ravi/master/eslint-v9
branch
from
f481857 to
6eec0f1
Compare
|
@wjhsf Decided to drop support for v7 and v8 for the following reasons:
|
ravijayaramappa
added a commit
that referenced
this pull request
Jan 4, 2025
* feat!: update dependency to eslint v9 @W-17445058 BREAKING CHANGE: dropping support for ESLint v7 and v8. The only supported option is ESLint v9 * fix: lock file update * fix: update ci config * feat: migrate rule to ESLint v9 * fix: address PR feedback
ravijayaramappa
added a commit
that referenced
this pull request
Jan 18, 2025
* feat!: update dependency to eslint v9 @W-17445058 BREAKING CHANGE: dropping support for ESLint v7 and v8. The only supported option is ESLint v9 * fix: lock file update * fix: update ci config * feat: migrate rule to ESLint v9 * fix: address PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: dropping support for ESLint v7 and v8. Supported option is ESLint v9 only. Use older versions of this plugin to use ESLint v7 and v8.
fixes #150