Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade static analyzer and other miscellaneous dependency #56

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Upgrade static analyzer and other miscellaneous dependency #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5712cf7
update static-analyzer version
ben-zhang-at-salesforce Jan 13, 2025
e6f1a39
upgrade eslint-plugin-eslint-plugin
ben-zhang-at-salesforce Jan 13, 2025
53544e8
Merge branch 'main' into upgrade-static-analyzer
ben-zhang-at-salesforce Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ updates:
- dependency-name: '@salesforce/dev-scripts'
# Don't upgrade Komaci until we meet its respective release boundary.
- dependency-name: '@komaci/static-analyzer'
versions: ['>= 252.0.0']
versions: ['>= 254.0.0']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 252 or 254 as you have it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should 254. My understanding is this versions is for dependabot to ignore if dependabot detects there's >= 254 version. it will create pr if less than 254. so manual pr for cross version, auto pr if still in 252.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"!**/test/"
],
"devDependencies": {
"@babel/eslint-parser": "7.25.9",
"@babel/eslint-parser": " 7.26.5",
"prettier": "^3.4.2",
"jest": "^29.7.0",
"jest-extended": "^4.0.2",
Expand All @@ -54,7 +54,7 @@
"chai": "^4.5.0"
},
"dependencies": {
"@komaci/static-analyzer": "^250.0.2",
"@komaci/static-analyzer": "^252.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the latest published static analyzer: 252.1.0. will do an update when 254 is published.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 254 of static-analyzer hasn't been deployed to npmjs.com yet. so we still can't refer it as dependency yet.

https://www.npmjs.com/package/@komaci/static-analyzer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we won't want to until we pull the trigger on 254 support—soon after the final deployment, is when we'll likely take that on. 👍

"@lwc/metadata": "3.5.0-0",
"@lwc/sfdc-compiler-utils": "3.5.0-0",
"@lwc/errors": "~3.5.0",
Expand Down
26 changes: 13 additions & 13 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@
json5 "^2.2.3"
semver "^6.3.1"

"@babel/eslint-parser@7.25.9":
version "7.25.9"
resolved "https://registry.yarnpkg.com/@babel/eslint-parser/-/eslint-parser-7.25.9.tgz#603c68a63078796527bc9d0833f5e52dd5f9224c"
integrity sha512-5UXfgpK0j0Xr/xIdgdLEhOFxaDZ0bRPWJJchRpqOSur/3rZoPbqqki5mm0p4NE2cs28krBEiSM2MB7//afRSQQ==
"@babel/eslint-parser@ 7.26.5":
version "7.26.5"
resolved "https://registry.yarnpkg.com/@babel/eslint-parser/-/eslint-parser-7.26.5.tgz#aa669f4d873f9cd617050cf3c40c19cd96307efb"
integrity sha512-Kkm8C8uxI842AwQADxl0GbcG1rupELYLShazYEZO/2DYjhyWXJIOUVOE3tBYm6JXzUCNJOZEzqc4rCW/jsEQYQ==
dependencies:
"@nicolo-ribaudo/eslint-scope-5-internals" "5.1.1-v1"
eslint-visitor-keys "^2.1.0"
Expand Down Expand Up @@ -664,23 +664,23 @@
"@jridgewell/resolve-uri" "^3.1.0"
"@jridgewell/sourcemap-codec" "^1.4.14"

"@komaci/common-shared@250.0.2":
version "250.0.2"
resolved "https://registry.yarnpkg.com/@komaci/common-shared/-/common-shared-250.0.2.tgz#0ef433f6b2f683e01bb5a7c89ba2fa10006a5d9d"
integrity sha512-wNw7vt+7KFiIuhOjcZRnek9iNSWyRqaRmotVu9SFz7fwkeXsi+TdQU2Ti5Lf8jdKfwh9jrhII5ROC69ZsIxqOA==
"@komaci/common-shared@252.1.0":
version "252.1.0"
resolved "https://registry.yarnpkg.com/@komaci/common-shared/-/common-shared-252.1.0.tgz#55d901a012d799ff52ad2fb7855b022868827dd8"
integrity sha512-1yrQhWooyIOPGdmDubDLQJ7I/pcWtSxCwf9Cdls4TUVrM5IFYfy33w+KH4hEVzQGWfpv3vEEPqH8W+GdzoLUOQ==
dependencies:
"@babel/core" "^7.9.0"
"@babel/generator" "^7.9.0"
"@babel/parser" "^7.9.0"
"@babel/types" "^7.9.0"

"@komaci/static-analyzer@^250.0.2":
version "250.0.2"
resolved "https://registry.yarnpkg.com/@komaci/static-analyzer/-/static-analyzer-250.0.2.tgz#d0a0b7db96cf7f19a31bdb15ad9948778039ddce"
integrity sha512-bj+/qe4U8utXed3/HGTAdJWOIP6yGcJ3ylZvAI47lBasW0xcDjEiarWQH+8X8+HhopC4aaAS6qrEC6CrxqsBSA==
"@komaci/static-analyzer@^252.1.0":
version "252.1.0"
resolved "https://registry.yarnpkg.com/@komaci/static-analyzer/-/static-analyzer-252.1.0.tgz#e45d9301e5912c4a24a983ee515e4deafa04e1f6"
integrity sha512-CfWsBJFT+K8DNGOxi6NxZZAWeZ4PXdFyU5THGzAKlWD0T0mw58eMVgS+U7bV4MRmEAGfygoZnhxYErFjUZA5PQ==
dependencies:
"@babel/types" "^7.9.0"
"@komaci/common-shared" "250.0.2"
"@komaci/common-shared" "252.1.0"

"@lwc/[email protected]", "@lwc/errors@~3.5.0":
version "3.5.0"
Expand Down
Loading