This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Switch to [email protected] #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansin
commented
May 2, 2018
| @@ -1,4 +1,6 @@ | |||
| .generated | |||
| .idea | |||
There was a problem hiding this comment.
Not sure what your standards are, but I thought it'd be fine to add an IDE specific (IntelliJ in this instance) folder to .gitignore.
cansin
commented
May 2, 2018
| @@ -16,5 +16,9 @@ | |||
| "scripts": { | |||
| "dev": "gulp dev", | |||
| "prestart": "gulp" | |||
| }, | |||
| "engines": { | |||
| "node": ">=8.9.1", | |||
There was a problem hiding this comment.
There was not an engine information for the node version, so I set it to the version that we use. I can replace it whatever version that this project normally assumes.
cansin
commented
May 2, 2018
| }, | ||
| "engines": { | ||
| "node": ">=8.9.1", | ||
| "yarn": ">=1.3.2" |
There was a problem hiding this comment.
This is the yarn version I generated the lock file with. Though, the latest yarn version is 1.6.0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7. As I stated there, feel free to close this PR if you do not want to switch to
yarn. This is just a pre-emptive PR in case you'd like to.