Replace Service Worker with a noop #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8504316 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Cloud11PL
force-pushed
the
MERX-202-sw-error
branch
from
6cd88ce to
151f42b
Compare
poulch
previously approved these changes
Apr 18, 2024
package.json
Outdated
| "workbox-precaching": "^6.1.2", | ||
| "workbox-routing": "^6.1.2", | ||
| "workbox-strategies": "^6.1.2" | ||
| "vite-plugin-pwa": "^0.19.8" |
There was a problem hiding this comment.
Question: do we still need pwa plugin?
There was a problem hiding this comment.
Good point. I kept it because we need to load sw.js alongside all js chunks somehow. I'll look into keeping it as a static file.
There was a problem hiding this comment.
@krzysztofzuraw It seems we do not :)
Cloud11PL
force-pushed
the
MERX-202-sw-error
branch
from
b6320ba to
715486a
Compare
Cloud11PL
force-pushed
the
MERX-202-sw-error
branch
from
55874ea to
de3cc67
Compare
poulch
approved these changes
Apr 23, 2024
krzysztofzuraw
approved these changes
Apr 23, 2024
poulch
pushed a commit
that referenced
this pull request
Apr 23, 2024
* we * replace sw with noop * update messages * changesets * remove unused npm pkg * statically serve sw * trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description