Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel creation transaction flow settings #4792

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

Cloud11PL
Copy link
Member

@Cloud11PL Cloud11PL commented Apr 12, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

Description

  • fixes an issue where settings for transaction flow in channel create were not saved
  • fixes an issue where in channel create initial click on checkbox doesn't do anything
  • sorts some props alphabetically for better visibility

@Cloud11PL Cloud11PL requested a review from a team as a code owner April 12, 2024 12:54
Copy link

changeset-bot bot commented Apr 12, 2024

🦋 Changeset detected

Latest commit: ff94575

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-4792 April 12, 2024 12:57 Destroyed
@Cloud11PL Cloud11PL requested a review from a team April 15, 2024 10:37
poulch
poulch previously approved these changes Apr 15, 2024
@Cloud11PL Cloud11PL requested a review from a team as a code owner April 18, 2024 09:49
@github-actions github-actions bot temporarily deployed to pr-4792 April 18, 2024 09:51 Destroyed
yellowee
yellowee previously approved these changes Apr 18, 2024
@Cloud11PL Cloud11PL force-pushed the MERX-263-fix-channel-create branch from 70acb6d to c4df07f Compare April 18, 2024 12:02
@github-actions github-actions bot temporarily deployed to pr-4792 April 18, 2024 12:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4792 April 18, 2024 12:41 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4792 April 22, 2024 09:21 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4792 April 22, 2024 09:55 Destroyed
@Cloud11PL Cloud11PL force-pushed the MERX-263-fix-channel-create branch from 9ad6063 to 3b25203 Compare April 22, 2024 12:06
@github-actions github-actions bot temporarily deployed to pr-4792 April 22, 2024 12:08 Destroyed
@Cloud11PL Cloud11PL merged commit db8b2d9 into main Apr 23, 2024
15 checks passed
@Cloud11PL Cloud11PL deleted the MERX-263-fix-channel-create branch April 23, 2024 08:30
poulch added a commit that referenced this pull request Apr 23, 2024
* fix channel creation flow settings

* add pw tests and small improvements

* add disabled to checkboxes

* trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants