Upgrade actions/upload-artifact to v4 (#5325) (#5349)

* Upgrade actions/upload-artifact to v4 (#5325) * Remove not used action combine-e2e-results * Use v4 upload and download artifacts * Use shard * Extract shard index * Add shell * Add changeset * Generate report name * Generate report name in one step * Generate report name in one step v2 Cherry picked from merx-1360-updte-upload-action-artifact * Fix report name --------- Co-authored-by: Paweł Chyła <[email protected]>
saleor · Jan 16, 2025 · 53cb75e · 53cb75e
1 parent d4f9d5c
commit 53cb75e
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 57 deletions.
diff --git a/.changeset/dirty-toes-tan.md b/.changeset/dirty-toes-tan.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Now CI workflows use updated action to upload and download artifacts
diff --git a/.github/actions/combineReportsFromE2E/action.yml b/.github/actions/combineReportsFromE2E/action.yml
diff --git a/.github/actions/merge-pw-reports/action.yml b/.github/actions/merge-pw-reports/action.yml
@@ -13,17 +13,18 @@ runs:
       run: npm ci
 
     - name: Download blob reports from GitHub Actions Artifacts
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
-        name: all-blob-reports
         path: all-blob-reports
+        pattern: all-blob-reports-*
+        merge-multiple: true
 
     - name: Merge into HTML Report
       shell: bash
       run: npx playwright merge-reports --reporter html ./all-blob-reports
 
     - name: Upload HTML report
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: html-report--attempt-${{ github.run_attempt }}
         path: playwright-report

diff --git a/.github/actions/run-pw-tests/action.yml b/.github/actions/run-pw-tests/action.yml
@@ -77,12 +77,14 @@ runs:
         URL_TO_RUN: ${{ inputs.URL_TO_RUN }}
         WORKERS: ${{ inputs.PW_WORKERS }}
         RETRIES: ${{ inputs.PW_RETRIES }}
-      run: npm run qa:pw-e2e -- --shard "$SHARD_NUMBER"
+      run: |
+        echo "reportName=all-blob-reports-${SHARD_NUMBER%%/*}" >> $GITHUB_ENV
+        npm run qa:pw-e2e -- --shard "$SHARD_NUMBER"
 
     - name: Upload blob report to GitHub Actions Artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       if: always()
       with:
-        name: all-blob-reports
+        name: ${{ env.reportName }}
         path: blob-report
         retention-days: 1